feat: support transfer tx fee deduction from amount#89
Open
jairajdev wants to merge 2 commits into
Open
Conversation
- add recipientPaysTxFee as an optional transfer payload field - gate recipient-paid fee behavior behind the 2.4.9 supportRecipientPaysTxFee version flag - deduct successful transfer tx fees from the recipient when opted in - keep failed transfer tx fees charged to the sender
jairajdev
changed the title
jairajdev
force-pushed
the
recipient-pays-transfer-tx-fee
branch
from
12c6384 to
9790466
Compare
- add deductTxFeeFromAmount as an optional transfer payload field - gate the behavior behind the 2.4.9 supportDeductTxFeeFromAmount version flag - deduct successful transfer tx fees from the transfer amount when opted in - document that receipt amount reflects the net amount received when fee is deducted - add a commented client transfer option for deductTxFeeFromAmount
jairajdev
force-pushed
the
recipient-pays-transfer-tx-fee
branch
from
9790466 to
47502fc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
add deductTxFeeFromAmount as an optional transfer payload field
gate the behavior behind the 2.4.9 supportDeductTxFeeFromAmount version flag
deduct successful transfer tx fees from the transfer amount when opted in
record deductedFee in receipts only when the transfer amount paid the tx fee
document that receipt amount reflects the net amount received when fee is deducted
add a commented client transfer option for deductTxFeeFromAmount